This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Expand web3.js transport method wrapping to improve error reporting #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend from base TruffleError - Match underlying web3.js error message against known messaging - Use message type to define "friendly error" for failures to connect Note: - web3.js reports "Invalid JSON RPC response" in place of some kind of error indicating invalid connection. This seems to be a bug? - String matching seems to be the only way to interpret web3 errors (web3.js throws base JS `Error`, not any subclass, unfortunately) - This error class is therefore likely to be brittle
- Define transport hooks to run before / after sending - Wrap errors with ProviderError
|
@tcoulter would appreciate your thoughts on approach, as well as if you happen to see any stylistic things that I could improve. (mostly trying to sketch out an idea, added comments in hopes they'll help) |
gnidan
commented
Jul 17, 2017
| " - is properly configured in your Truffle configuration file (truffle.js)\n"; | ||
| } | ||
| ProviderError.super_.call(this, message); | ||
| this.message = message; |
There was a problem hiding this comment.
I found this pattern in truffle-compile but I don't know if any of that is extraneous here.
gnidan
commented
Jul 17, 2017
| var modified = postHook(payload, error, result); | ||
| payload = modified[0]; | ||
| error = modified[1]; | ||
| result = modified[2]; |
There was a problem hiding this comment.
I'm taking this approach specifically to modify the error that gets thrown, but it doesn't work as nicely without being able to return multiple values.
Wondering if there's a less awkward way to do this same thing (if only we could use fancy new destructuring :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: trufflesuite/truffle#489
Mainly,
ProviderErrorclassNote on error implementation:
web3.js reports "Invalid JSON RPC response" in place of some kind of error indicating invalid connection. This seems to be a bug?
String matching seems to be the only way to interpret web3 errors (web3.js throws base JS
Error, not any subclass, unfortunately)